notify reactions #2331
Open
notify reactions #2331
+74
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/notify-reactions
branch
from
d7b19d0
to
d770563
Compare
r10s
force-pushed
the
r10s/notify-reactions
branch
from
8c50d49
to
fdc0ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR shows notifications for reactions to one's own messages.
requires a core with deltachat/deltachat-core-rust#6072
this is how it looks like on the lock screen:
the accumulation is done when we discover multiple messages/reaction when processing a PUSH notification in the "notification service extension", where we can only modify the single, given notification, but not add additional ones (often, this accumulation is not needed, as PUSH notifications receive in time and one-per-one)